Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mtrofin
deleted the
users/mtrofin/12-08-fix_test_outputting_to_test_dir
branch
|
Sorry for breaking the builds, and thanks for the fix. I thought piping to FileCheck wasn't necessary since the test doesn't use CHECK lines. It appears FileCheck handles the temporary file deletion. |
No worries, it happens! btw, it's not FileCheck. Rather, if you:
|
The test introduced in llvm#171118 has `llc` inadvertently producing an output into the same dir as the test file itself. Most build bots don't clean up the local git repo, which is assumed to not be written by build + test, and patch on top (for build performance reasons), which means the produced output from the aforementioned PR is treated as a test from here onwards, by all bots. Since it's missing `RUN` lines, we get errors, for example https://lab.llvm.org/buildbot/#/builders/108/builds/20674 This patch fixes the `llc` line and also removes the `.s`. This avoids all bot maintainers go restart their bots. Then, the cleanup is removed in llvm#171256.
This follows #171255 , removing the cleanup line.
This follows llvm#171255 , removing the cleanup line.
3 participants
The test introduced in #171118 has
llcinadvertently producing an output into the same dir as the test file itself. Most build bots don't clean up the local git repo, which is assumed to not be written by build + test, and patch on top (for build performance reasons), which means the produced output from the aforementioned PR is treated as a test from here onwards, by all bots. Since it's missingRUNlines, we get errors, for example https://lab.llvm.org/buildbot/#/builders/108/builds/20674This patch fixes the
llcline and also removes the.s. This avoids all bot maintainers go restart their bots. Then, the cleanup is removed in #171256.